search

CineEncoder / cine-encoder

Cine Encoder is an application that allow to convert media files while preserving HDR metadata.
GNU General Public License v3.0
98 stars 12 forks source link

Incorrect program window title #19

Closed danfe closed 3 years ago

danfe commented 3 years ago

I've left two comments to the commit 540bc30 which broke it, but they went unanswered, so I guess I have to open an issue instead. Consider the following patch:

@@ -11,7 +11,7 @@
    </rect>
   </property>
   <property name="windowTitle">
-   <string>Form</string>
+   <string>Cine Encoder 2021</string>
   </property>
   <property name="windowIcon">
    <iconset resource="files.qrc">
CineEncoder commented 3 years ago

Hi! I saw the commit 540bc30, but I thought that it was sent by mistake, because there was no comment and I did not find any changes, it seemed to me that just a copy of the project was sent (besides, it would roll back the project to the old version). I accept the WindowTitle change, but since I use FramelessWindowHint, the window title is not visible.

danfe commented 3 years ago

I thought that it was sent by mistake, because there was no comment and I did not find any changes

I see, I guess it's because the commit is so huge that GitHub collapses most parts of it, including the comments; I should have thought of it, sorry.

I use FramelessWindowHint, the window title is not visible.

I understand, but window title is also displayed in e.g. Alt-Tab window list in most window managers when switching windows.

CineEncoder commented 3 years ago

window title is also displayed in e.g. Alt-Tab window list in most window managers when switching windows.

I've overlooked that. Thanks! I have committed this change.

danfe commented 3 years ago

Fixed in 6fd2a0f (unfortunately, together with other, unrelated changes).