search

CinemaMod / mcef

A Minecraft mod and library for adding the Chromium web browser into the game (Minecraft Chromium Embedded Framework)
GNU Lesser General Public License v2.1
70 stars 24 forks source link

MCEF Fails to get a Java CEF Commit, Causing crashes #56

Closed Blobanium closed 11 months ago

Blobanium commented 11 months ago

Crash log: crash-2023-10-05_23.18.02-client.txt

A Little Bit of looking through the code reveals that this only happens when MCEF is being run from a JAR, not a development environment.

Looking a little bit closer within the code and a little bit of decompiling the JAR revealed that the java-cef-commit property within MANIFEST.MF for whatever reason isn't being included. (See image below) image

Reference: https://github.com/CinemaMod/mcef/blob/e5a762a671ac8eb28ba00dbba433e16cb06007f9/common/src/main/java/com/cinemamod/mcef/MCEF.java#L108

I know i could implement a temp workaround. (id probably add a config option or a -D Flag or something)

ds58 commented 11 months ago

Fixed in the release