search

CinemaMod / mcef

A Minecraft mod and library for adding the Chromium web browser into the game (Minecraft Chromium Embedded Framework)
GNU Lesser General Public License v2.1
74 stars 24 forks source link

Fix JCEF Commit not being found on runtime. #57

Closed Blobanium closed 1 year ago

Blobanium commented 1 year ago

fixes #56

I also added the ability to specify the Jcef commit using a JVM Arg in case getting the commit fails.

i did add more details in comments within the code i changed.

GiantLuigi4 commented 1 year ago

Unsure what ds would say (as he is the maintainer of the project), but personally I would've stuck with the config Bit easier to tell someone to edit a config than it is to tell them to edit the JVM args, especially considering I believe CurseForge's launcher doesn't have a dedicated feature for JVM args

Blobanium commented 1 year ago

Unsure what ds would say (as he is the maintainer of the project), but personally I would've stuck with the config Bit easier to tell someone to edit a config than it is to tell them to edit the JVM args, especially considering I believe CurseForge's launcher doesn't have a dedicated feature for JVM args

I technically did that because that value would be only used in case getting the commit fails. I Could change the code up a little bit and have it use the manual jcef commit regardless if specified by the user. I also could go back to using a config option instead of using JVM Args. But i want to see what ds says first.

ds58 commented 1 year ago

I ended up adding these changes manually with some tweaks. Thanks for the fix!