CirQuS-UTS / QuanGuru

QuanGuru (pronounced Kangaroo) is a Python library for numerical modelling of quantum systems. It is still under-development, and it consists of tools for numerical simulations of Quantum systems.
BSD 3-Clause "New" or "Revised" License
5 stars 7 forks source link

Simulating Pulse Trains #213

Open adriendilonardo opened 2 years ago

adriendilonardo commented 2 years ago

Please describe the expected enhancement

Context

Suggested Implementations

Instead of using nested simulations to simulate these pulse trains, we should use nested protocols:

risingEdge = qg.pulse(system=total_sys, simulation=simulation)
flatTop = qg.protocol(system=total_sys, createUnitary=qg.UJC)
fallingEdge = risingEdge.transpose

pulseTrain = qg.protocol(steps=[risingEdge, flatTop, fallingEdge])

There are some key points to this implementation:

Note the unitary for fallingEdge should be stored within ITSELF

github-actions[bot] commented 2 years ago

Branch 213-Simulating_Pulse_Trains created!

github-actions[bot] commented 2 years ago

Could not create PR (Update is not a fast forward)

cahitkargi commented 2 years ago

Let's discuss and divide it into tasks that we can individually implement. we want:

Is this list complete?

adriendilonardo commented 2 years ago

Yes, this list is complete :)

Just some notes in response to the first dot point: