search

CircleCI-Archived / api-preview-docs

In-progress docs about the pre-release preview of CircleCI API v2
72 stars 26 forks source link

Reword/fix the text around `when` keys #29

Closed sulami closed 5 years ago

sulami commented 5 years ago

Thinking about it I don’t like “dropped”. I’ll ponder over that

--

Robin Schroer On 26 Jun 2019, 18:18 +0200, Nathan Dintenfass notifications@github.com, wrote:

@ndintenfass commented on this pull request. In designs-for-feedback/trigger-workflows-in-pipeline.md:

@@ -62,11 +62,10 @@ unless it was invoked explicitly when the pipeline is triggered with: }

-The nested condition key is reused from job configuration as can be seen below -for the deploy job, and actually accepts any boolean, not just pipeline -parameters. It is needed to signify that this value is evaluated at -configuration compilation time, as opposed to a possible future addition that -could be evaluated at run time. +The when key actually accepts any boolean, not just pipeline parameters, +though pipeline parameters will be the only meaningful use of this feature until +we implement others. Note that the nested condition key used in conditional +jobs has been dropped, as there is no intrinsic need for it in this situation. I don't think we need to talk about it as dropped. We do need to think hard about rationalizing that when in this case is a sub-key of the workflow, whereas in the case of the when step command it is "above" the steps stanza, and on a step itself it's a subkey -- this inconsistency is not great, but perhaps tolerable. Should it be a different word, or do we live with it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.