CircleCI-Archived / visual-config-editor

Generate your CircleCI configuration files by building a visual map of your project's workflows.
https://circle.ci/visual-config-editor
Apache License 2.0
73 stars 17 forks source link

Bug: `add_ssh_keys` not accepted when doing an import #283

Open mathaeus opened 2 years ago

mathaeus commented 2 years ago

Is there an existing issue for this?

Current behavior

The regular add_ssh_keys is not accepted by the VCE.

Screenshot 2022-09-08 at 16 27 56

Minimum reproduction code

https://gist.github.com/mathaeus/972c9e4ee827077b1a24d64a0e043978

Steps to reproduce

Import config with add_ssh_keys

Expected behavior

The import of existing valid circleCI config files should just work.

Workaround

Changing

add_ssh_keys

to

add_ssh_keys: {}

fixes the problem.

BUT, such things are quite annoying when one once to get started with the VCE. Especially if one triple checked that the current manually written config is valid via

> circleci config validate
Config file at .circleci/config.yml is valid.

CircleCI Config SDK version

Whatever the online editor gave me:

# This configuration has been automatically generated by the CircleCI Config SDK.
# For more information, see https://github.com/CircleCI-Public/circleci-config-sdk-ts
# SDK Version: 0.9.0-alpha.16
# VCE Version: v0.10.5
# Modeled with the CircleCI visual config editor.
# For more information, see https://github.com/CircleCI-Public/visual-config-editor

Node.js version

No response

In which operating systems have you tested?

Other

No response

Jaryt commented 2 years ago

This is actually a Config SDK Parser issue, and I've closed this in https://github.com/CircleCI-Public/circleci-config-parser-ts/pull/14 (Project is currently internal, will get that updated) Thanks for raising!

mathaeus commented 2 years ago

Thanks @Jaryt šŸ‘

Jaryt commented 2 years ago

Thanks @Jaryt šŸ‘

No problem! I'll actually reopen this until we have the updated version of the parser in the VCE.