removed arguements from the get command.

CircleCI-Public / aws-code-deploy-orb

Easily deploy applications to AWS CodeDeploy on CircleCI with the aws-code-deploy orb

https://circleci.com/orbs/registry/orb/circleci/aws-code-deploy

MIT License

9 stars 13 forks source link

removed arguements from the get command. #7

Closed btv closed 2 years ago

btv commented 4 years ago

Potential fix for #6, however I'm sure this change is incomplete. Please let me know if anything would need to be done to get this completed.

gmemstr commented 4 years ago

I think a better approach is what is described in the linked issue - having two different parameters, one for create and another for get - it would break backwards compatibility, however.

btv commented 4 years ago

@gmemstr I respect the position about coming up with a better fix for this problem, however, it would be nice to have something working immediately. I'm thinking of this PR more as a patch release to at least get current functionality working, which would provide time for the more thorough release at a later date.

EricRibeiro commented 2 years ago

Looks like this was included in #11.