search

CircleCI-Public / aws-ecr-orb

CircleCI orb for interacting with Amazon's Elastic Container Registry (ECR)
https://circleci.com/orbs/registry/orb/circleci/aws-ecr
MIT License
80 stars 142 forks source link

New aws-cli/setup configuration parameter: working_directory #223

Closed lewalt000 closed 2 years ago

lewalt000 commented 2 years ago

What would you like to be added

It would be very useful to add working_directory as a configuration parameter to the aws-cli/setup command.

Why is this needed

Some jobs set a default working_directory for the entire job, which also effects orb installs. I've observed this orb fail to install with error environment: line 29: $1: unbound variable, which is fixed by removing the working_directory for the entire job. Therefore, it would be very useful to be able to set a different working_directory for the aws-cli orb specifically, so the rest of a job can use a different default value.

As an example, the cypress orb has this feature: https://github.com/cypress-io/circleci-orb/blob/master/docs/examples.md#custom-directory.

I'm also open to submitting a PR if any project maintainer can comment on this idea. Thank you!

lewalt000 commented 2 years ago

opened this in the wrong repo, closing and re-opening in aws-cli-orb repo