fix: extra-build-args expansion

CircleCI-Public / aws-ecr-orb

CircleCI orb for interacting with Amazon's Elastic Container Registry (ECR)

https://circleci.com/orbs/registry/orb/circleci/aws-ecr

MIT License

81 stars 142 forks source link

fix: extra-build-args expansion #254

Closed brivu closed 1 year ago

brivu commented 1 year ago

This PR separates the expansion of the extra-build-args from the $@ array and expands with ${ORB_EVAL_EXTRA_BUILD_ARGS:+$ORB_EVAL_EXTRA_BUILD_ARGS} at runtime.

morloderex commented 1 year ago

@brivu can we have a bugfix release for this asap. I have been waiting to use 8.2.0 for a while now by using a random development build which I think is somewhat out of date soon.

EricRibeiro commented 1 year ago

@morloderex, Brian released the fix on v8.2.1.

swiknaba commented 1 year ago

@brivu thanks for working on this! Any idea, why this is still broken with my config? What differs from the spec in this PR is passing multiple args not only one. https://github.com/CircleCI-Public/aws-ecr-orb/issues/269 -- Highly appreciate any help 🙇