CircleCI-Public / aws-ecr-orb

CircleCI orb for interacting with Amazon's Elastic Container Registry (ECR)
https://circleci.com/orbs/registry/orb/circleci/aws-ecr
MIT License
81 stars 142 forks source link

aws-ecr/login Fails with Error about the wrong AWS_REGION #268

Closed martyzz1 closed 1 year ago

martyzz1 commented 1 year ago

Orb version

8.2.1

What happened

I get errors running aws-ecr/login

Provided region_name 'AWS_REGION' doesn't match a supported format. Error: Cannot perform an interactive login from a non TTY device

Exited with code exit status 1 CircleCI received exit code 1

Expected behavior

login should work.

I am curious why your AWS_REGION parameter is configured differently to all your other parameters from env vars...

But funnily enough if I use the same Env Vars against an older version of your orb 7.3.3 Everything works fine. I think you have a bug in your interpretation of your "region" parameter which is not setting the region to the right value... e.g. it should be 'eu-west-1' but its not, its actually the string 'AWS_REGION'

martyzz1 commented 1 year ago

Closing this, as it looks like it was an issue with upgrading from version 7 to 8 in the change to the AWS_REGION moving from env_var_name to string type.