CircleCI-Public / aws-ecr-orb

CircleCI orb for interacting with Amazon's Elastic Container Registry (ECR)
https://circleci.com/orbs/registry/orb/circleci/aws-ecr
MIT License
80 stars 142 forks source link

feat: aws_url paramater #288

Closed brivu closed 1 year ago

brivu commented 1 year ago

Currently, the url to push and pull images from ecr is hardcoded as amazon.aws.com.

In other countries, the AWS domain may be different. For example, in China, the AWS domain is amazomaws.com.cn.

This PR implements the aws_domain, letting users specify a different AWS domain if necessary

brivu commented 1 year ago

Just added env subst! Thank you!