refactor: revert to eval

CircleCI-Public / aws-ecr-orb

CircleCI orb for interacting with Amazon's Elastic Container Registry (ECR)

https://circleci.com/orbs/registry/orb/circleci/aws-ecr

MIT License

80 stars 142 forks source link

refactor: revert to eval #321

Closed brivu closed 10 months ago

brivu commented 10 months ago

Version 9.0.0 of this orb replaced eval with cicleci env subst.

This had unintended consequences like:

expanding variables containing sub-shells
string operations (ie ${CIRCLE_SHA1:0:7})

This PR reverts back to using eval for variable expansion.

PLEASE NOTE: We will be reintroducing circleci env subst again in a later major release but just wanted to make this change to include bug fixes for folks using older versions of the orb.

eviln1 commented 9 months ago

:wave: @brivu any updates on the timeline for next release which will include this PR ?

summera commented 4 months ago

@brivu is there a reason why circleci env subst was left in place for AWS_ECR_STR_AWS_DOMAIN and AWS_ECR_STR_EXTRA_BUILD_ARGS? We have upgraded to v9, but we're having trouble with some env var substitution with extra build args where an environment variable of ours is no longer being substituted with the value. It was working as expected in the latest v8 version.

summera commented 4 months ago

@bjohnso5 in case @brivu is no longer part of the project, just wanted to tag you for visibility on my question above. Thanks in advance!

brivu commented 3 months ago

Hey @eviln1 and @summera,

I am no longer working at CircleCI. I think your best bet is reaching out to support.

Good luck!