CircleCI-Public / aws-ecr-orb

CircleCI orb for interacting with Amazon's Elastic Container Registry (ECR)
https://circleci.com/orbs/registry/orb/circleci/aws-ecr
MIT License
79 stars 140 forks source link

All image builds broken until new release occurs #332

Closed Andy-Bell closed 6 months ago

Andy-Bell commented 7 months ago

Orb version

All versions without this commit

What happened

With the rolling brownouts, all deployments using this orb are failing as the image cannot be found

dnoji commented 7 months ago

@brivu Can you give an update on this one? Can you push another release with the referenced commit? This is creating some major issues for our workflows.

gabrielqs commented 7 months ago

seeing the same problems on our pipelines. can't setup any pipelines with DLC enabled on 9.0.3 (it doesn't allow me to setup remote docker on the docker executor) and i can't use 9.0.2 because its on a deprecated image. i wonder how this deprecation happened so fast, even for circle. this has been disrupting all of our pipelines since this morning. and i assumed my pipelines were all safe knowing i was relying on almost up-to-date circleci orbs.

mrj0 commented 7 months ago

Aw man, I was just here trying to update to 9.0.2 from 8 and having a bad time due to changes.. to find it won't actually fix my problem :-/

drdaeman commented 7 months ago

I'm not sure how it's broken - the referenced commit seems to only apply to an example YAML file (which, AFAIK, is not really used when using this orb) and a CI pipeline used to build this orb. There are no changes from src/ outside of src/examples/.

FWIW, my pipelines using 8.2 version had somehow worked today. I've stumbled upon this issue looking for v9 upgrade docs, deciding to future-proof my CI config.

Andy-Bell commented 7 months ago

In case anyone is coming here because builds are broken due to the default executor image not being found, you can specify a custom executor for the build_and_upload job which you can specify using one of the approved images.

cglango commented 7 months ago

@Andy-Bell Can you give an example?

Virtim commented 7 months ago

Came here with a similar problem, though with another version of the orb. There is a parameter with which you can setup remote docker version which helps with resolving deprecation

For older version of the orb use this: remote-docker-version: default

With the current version (9.0.4) syntax has changed a bit so you should use remote_docker_version: default

A complete example of the build-and-push image step:

      - aws-ecr/build-and-push-image:
          repo: "repo"
          setup-remote-docker: true
          remote-docker-version: default

you can change default to other docker versions, you can find what options do you have in the documentation here: https://circleci.com/docs/remote-docker-images-support-policy/#release-policy

brivu commented 6 months ago

Hey everyone,,

My apologies but I no longer work at CircleCI due to a recent RIF. Your best points of contact would be @brentmmarks and @bjohnso5.

It's been a pleasure! -Brian

2shortplanks commented 6 months ago

With regards to the brownout in 2024 with the deprecated images, this usually happens because older versions of the orb pull in a deprecated image by default. If you are using an old orb you have three options to avoid using a deprecated image.

  1. Update the version of the orb that you are using to use version 9.0.2 or later.
  2. Use the image parameter for the default executor to specify a non deprecated image (e.g. ubuntu-2004:current). This avoids having to update to a later version of the orb if you cannot use a later version.
  3. Manually specify an executor that uses a non deprecated image, for example by using the executor parameter for the build_and_push_image job. This option gives you the most flexibility.