search

CircleCI-Public / aws-ecr-orb

CircleCI orb for interacting with Amazon's Elastic Container Registry (ECR)
https://circleci.com/orbs/registry/orb/circleci/aws-ecr
MIT License
80 stars 142 forks source link

Bugfix: PATH parameter does not override BUILD_PATH parameter as docs suggest #342

Closed DevBaca closed 2 months ago

DevBaca commented 5 months ago

Orb version

9.1.0

What happened

The parameter description for path on the build_and_push_image job is incorrect.

PATH does not ever seem to override BUILD_PATH and specifying a non-default PATH parameter leaves the BUILD_PATH as the default.

Example of build path from the script: https://github.com/CircleCI-Public/aws-ecr-orb/blob/master/src/scripts/docker_buildx.sh#L97

Note that in none of the jobs/commands leading up to the call of the build_image script never overwrites BUILD_PATH

Expected behavior

Either we update the description or update the code in a way that handles PATH overriding the default BUILD_PATH when specified. If we go the latter, then also make sure we allow for both PATH and BUILD_PATH to be specified without BUILD_PATH being overwritten.

marboledacci commented 2 months ago

The description is updated in version https://circleci.com/developer/orbs/orb/circleci/aws-ecr?version=9.3.2