search

CircleCI-Public / aws-ecs-orb

An orb that simplifies deployment to Amazon's Elastic Container Service (ECS). Supports both EC2 and Fargate launch types.
https://circleci.com/orbs/registry/orb/circleci/aws-ecs
MIT License
51 stars 80 forks source link

feat: container-secrets-updates for ECS Task Definition #123

Closed jychen7 closed 2 years ago

jychen7 commented 3 years ago

Describe Request:

Similar to container-env-var-updates, Use this to update or set the references of secret variables that will be defined for the containers. The supported references are either the full ARN of the AWS Secrets Manager secret or the full ARN of the parameter in the AWS Systems Manager Parameter Store

https://github.com/CircleCI-Public/aws-ecs-orb/pull/27/files was trying to address it, but it was rejected because of not separating "environment" and "secrets"

Examples:

container-secrets-updates:
  container=<container-name>,name=<env-var-name>,valueFrom=<env-var-value>,container=...,name=...,valueFrom=...,

Supporting Documentation Links:

https://docs.aws.amazon.com/AmazonECS/latest/userguide/task_definition_parameters.html