search

CircleCI-Public / aws-ecs-orb

An orb that simplifies deployment to Amazon's Elastic Container Service (ECS). Supports both EC2 and Fargate launch types.
https://circleci.com/orbs/registry/orb/circleci/aws-ecs
MIT License
51 stars 80 forks source link

fix: Blue/Green deployment - moved timeout parameter to proper place #163

Closed geoL86 closed 2 years ago

geoL86 commented 2 years ago

Hi, this PR is about fix syntax mistake on parameter declaration.

For right now this parameter is ignored by the Circle CI and doesn't change step behavior. (https://github.com/CircleCI-Public/aws-ecs-orb/issues/133)

According to the docs the position of the parameter should be on another level: https://circleci.com/docs2/2.0/configuration-reference#ending-a-job-from-within-a-step

geoL86 commented 2 years ago

Hey @brivu , can you take a look to this small pr?

brivu commented 2 years ago

Hey @geoL86,

I got you! I'm testing these changes in my pipeline and will merge when it passes.

Best, Brian

brivu commented 2 years ago

Hey @geoL86,

I got you! I'm testing these changes in my pipeline and will merge when it passes.

Best, Brian

geoL86 commented 2 years ago

Hi @brivu , great news, one question - when new orb's release will happen?