search

CircleCI-Public / aws-ecs-orb

An orb that simplifies deployment to Amazon's Elastic Container Service (ECS). Supports both EC2 and Fargate launch types.
https://circleci.com/orbs/registry/orb/circleci/aws-ecs
MIT License
51 stars 80 forks source link

Command deploy-ecs-scheduled-task doesn't work #174

Closed kassyuz closed 2 years ago

kassyuz commented 2 years ago

Orb version:

3.0.0

What happened:

The command deploy-ecs-scheduled-task isn't work because there is bash command that doesn't exist, it is mktmp

Check it out at line 20 and 22 of the command source

Also the AWS CLI command aws events put-targets --cli-input-json "$(cat "$CLI_INPUT_FILE")" won't work because the JSON document must has at least two attributes, Rules and Targets, it only has Targets.

Expected behavior:

Use common bash command and have a proper JSON document.

kassyuz commented 2 years ago

I see the the fixes on master branch but any guess when will you have a release of it? @brivu

brivu commented 2 years ago

@kassyuz,

I'll have a new release ready by tomorrow!

Best, Brian

brivu commented 2 years ago

Hey @kassyuz,

I just cut a new release to include this fix: https://github.com/CircleCI-Public/aws-ecs-orb/releases/tag/v3.1.0

Hope that helps and let me know if there's anything else you need!

Best, Brian