fix: change `ORB_STR_RULE_NAME` validation to fail when the it's empty

CircleCI-Public / aws-ecs-orb

An orb that simplifies deployment to Amazon's Elastic Container Service (ECS). Supports both EC2 and Fargate launch types.

https://circleci.com/orbs/registry/orb/circleci/aws-ecs

MIT License

51 stars 80 forks source link

fix: change `ORB_STR_RULE_NAME` validation to fail when the it's empty #223

Closed diogonicoleti closed 1 month ago

diogonicoleti commented 1 month ago

refs to https://github.com/CircleCI-Public/aws-ecs-orb/issues/222

I changed the rule to verify if the ORB_STR_RULE_NAME is not empty (default value). Previously it was checking if it's not set but it's being set at line 9 with an empty value:

ORB_STR_RULE_NAME="$(circleci env subst "${ORB_STR_RULE_NAME}")"

and the rule name is required to invoke the next AWS CLI commands, if it's empty it'll fail