CircleCI-Public / aws-ecs-orb

An orb that simplifies deployment to Amazon's Elastic Container Service (ECS). Supports both EC2 and Fargate launch types.
https://circleci.com/orbs/registry/orb/circleci/aws-ecs
MIT License
51 stars 80 forks source link

Feature: job parameter region for all the commands and jobs #224

Closed marboledacci closed 1 month ago

marboledacci commented 1 month ago

This changes the way region is passed to to all jobs and commands in the orb. This used to be done using the environment variable values. The new parameter is set to used the AWS_DEFAULT_REGION env as a default when it is not set, this env was used for some other commands already. The change should be a major version as some of the commands are just using the default region defined in the profile or the defaults environment variables, and this won't work now as the region is always explicitly set. Also the way to pass the value is standardised to pass the value instead of the name of an environment variable. Anyway, an environment variable can be passed, but using the $ notation instead of just the name.