Set an optional parameter on whether to run update-task-definition in update-service.

CircleCI-Public / aws-ecs-orb

An orb that simplifies deployment to Amazon's Elastic Container Service (ECS). Supports both EC2 and Fargate launch types.

https://circleci.com/orbs/registry/orb/circleci/aws-ecs

MIT License

51 stars 80 forks source link

Set an optional parameter on whether to run update-task-definition in update-service. #88

Closed grimlock591 closed 4 years ago

grimlock591 commented 4 years ago

Checklist

[x] All new jobs, commands, executors, parameters have descriptions
[x] Examples have been added for any significant new features
[x] README has been updated, if necessary

Motivation, issues

This PR solves issue #85 to make the task update-task-definition optional since it is already run before.

Description

Add parameter run-update-task-definition to update-service. Run update-task-definition only when run-update-task-definition parameter is set to true, defaults to false.

grimlock591 commented 4 years ago

Happy new year @lokst I will look into the comments today

yuichiro12 commented 4 years ago

Any update?

grimlock591 commented 4 years ago

Apologies for being off the grid @lokst I'm going to look through and have this ready this weekend.

grimlock591 commented 4 years ago

@yuichiro12 @lokst made the suggested changes please look through

lokst commented 4 years ago

@Xheno Thank you so much, I'll take a look!

grimlock591 commented 4 years ago

Thank you so much @lokst I'll look through the changes and prep to see which issues I can pick up next.

lokst commented 4 years ago

@Xheno Thanks for your contribution! The changes have been published as version 1.2.0 of the orb 🎉