Use AWS_DEFAULT_REGION instead of AWS_REGION by default

CircleCI-Public / aws-s3-orb

Integrate Amazon AWS S3 with your CircleCI CI/CD pipeline easily with the aws-s3 orb.

https://circleci.com/orbs/registry/orb/circleci/aws-s3

MIT License

10 stars 20 forks source link

Use AWS_DEFAULT_REGION instead of AWS_REGION by default #27

Closed TheVaan closed 2 years ago

TheVaan commented 3 years ago

Is your feature request related to a problem? Please describe. All circleci/asw-* orbs I checked (cli, ecs, ecr) are using AWS_DEFAULT_REGION as environment variable by default for aws region. Except aws-s3. This orb uses AWS_REGION.

Describe the solution you'd like Instead of overwriting env variable name when running job it would be more intuive using the same env variable the other aws-* are using.

brivu commented 2 years ago

Hey @TheVaan,

I've been working on the other orbs and we've actually decided to change the default environment variable to AWS_REGION to be more aligned with the AWS documentation.

Thanks for contributing! -Brian