search

CircleCI-Public / aws-s3-orb

Integrate Amazon AWS S3 with your CircleCI CI/CD pipeline easily with the aws-s3 orb.
https://circleci.com/orbs/registry/orb/circleci/aws-s3
MIT License
10 stars 20 forks source link

Add optional override AWS credentials flag #29

Closed cesarcelism closed 2 years ago

cesarcelism commented 2 years ago

Is your feature request related to a problem? Please describe.

When you setup the aws CLI base on assume role (from aws-cli orb for example) if you don't setup the default env_var_name values on this orb.. the aws cli setup is overridden making fail the s3 operation

Describe the solution you'd like

Add a flag at aws-cli/setup step level to be optional and by default set in false

Describe alternatives you've considered

Other option is set the override variables regarding to aws.. but I think doesn't repeat the setup cli if you already setup before

Additional context

Setup of aws cli credentials could by env vars or by iam-role or by sts credentials too (session-token). All from aws-cli orb. This orb should be aware from those alternatives

cesarcelism commented 2 years ago

@KyleTryon I created PR to Alpha branch but show more changes that I made.. so created a draft point to master. Let me know if I need to do something else.