Closed brivu closed 1 year ago
The current version of this orb fails when providing more than one argument in the arguments parameter. With the way the orb is using eval, it injects single quotes around the arguments, causing the cli to throw an error:
arguments
eval
cli
aws s3 sync bucket s3://orb-testing-1/s3-orb **'--acl public-read --cache-control max-age=86400'** --profile OIDC-User Unknown options: --acl public-read --cache-control max-age=86400
This PR resolves this issue by removing the double quotes around the ${PARAM_AWS_S3_ARGUMENTS} variable in the bash script.
PR
${PARAM_AWS_S3_ARGUMENTS}
However, users must not use white spacing or quotations when providing arguments to the arguments parameter as it will cause issues with the expansion
The current version of this orb fails when providing more than one argument in the
argumentsparameter. With the way the orb is usingeval, it injects single quotes around thearguments, causing theclito throw an error:This
PRresolves this issue by removing the double quotes around the${PARAM_AWS_S3_ARGUMENTS}variable in the bash script.However, users must not use white spacing or quotations when providing arguments to the
argumentsparameter as it will cause issues with the expansion