CircleCI-Public / aws-sam-serverless-orb

AWS serverless Orb
https://circleci.com/orbs/registry/orb/circleci/aws-sam-serverless
MIT License
11 stars 25 forks source link

refactor!: orb tools 12 migration #60

Closed brivu closed 1 year ago

brivu commented 1 year ago

Description

This PR updates the AWS SAM Severless Orb to the new major version of Orb Tools. As it contains breaking changes, several modifications were unnecessary to move from v11 to v12.

Changes

  1. All parameters and commands containing dashes have been converted to the new snake case standard (replace - with _).
  2. The comprehensive list of changes can be found below.

Changes in .circleci/config.yml:

  1. Update the orb-tools version from 11.6 to 12.0.
  2. Move the job requirement list from orb-tools/publish to orb-tools/continue.
  3. Remove the orb-tools/publish job since development versions are no longer necessary.
  4. Add the new orb_name parameter in orb-tools/continue.
  5. Rename the orb-tools/continue job parameters to comply with the new snake case standard.
    • orb_name, pipeline_number and vcs_type.

Changes in .circleci/test-deploy.yml:

  1. Update the orb-tools version from 11.6 to 12.0.
  2. Remove the aws-cli: circleci/aws-cli@dev:<<pipeline.git.revision>> line, and replace it with aws-cli: {}.
  3. Remove the orb-tools/lint, orb-tools/pack, and orb-tools/review jobs. ⚠️
  4. Rename the orb-tools/publish job parameters to comply with the new snake case standard.
    • orb_name, vcs_type, pub_type, enable_pr_comment and github_token.
  5. Change the orb-tools/pack filter to trigger only on tagged releases.

⚠️: This change is not related to the migration itself. These jobs were redundant in test-deploy.yml as they already run in config.yml. See Orb-Template #2.