Fix yml #15 [semver:patch]

RonnyTite commented 3 years ago

Checklist

[x] All new jobs, commands, executors, parameters have descriptions
[ ] Examples have been added for any significant new features
[ ] README has been updated, if necessary

Motivation, issues

This PR is fixing #15

Description

The fix being to replace:

apt-get update

by

apt-get --allow-releaseinfo-change update

--allow-releaseinfo-change description :

Allow the update command to continue downloading data from a repository which changed its information of the release contained in the repository indicating e.g a new major release. APT will fail at the update command for such repositories until the change is confirmed to ensure the user is prepared for the change.

Source: https://manpages.debian.org/unstable/apt/apt-get.8.en.html

RonnyTite commented 2 years ago

@EricRibeiro Thanks for the feedback. Changes done ;) you can take a new look

EricRibeiro commented 2 years ago

One of the tests failed: https://app.circleci.com/pipelines/github/CircleCI-Public/azure-cli-orb/122/workflows/ac3c877b-3926-4a51-a68e-40146e1ab1b0/jobs/406?invite=true#step-101-50.

I'm not 100% sure without investigating but updating the test's executor images might do the trick. Both images used for testing this orb are outdated. The newest versions are cimg/go and cimg/python.

EricRibeiro commented 2 years ago

Thank you, @RonnyTite ✌️

It's all looking good now. We still need to update that golang image from the tests, but it's outside this PR's scope.

I'll push that change later.

EricRibeiro commented 2 years ago

v1.2.2 released with this fix: https://circleci.com/developer/orbs/orb/circleci/azure-cli?version=1.2.2.

CircleCI-Public / azure-cli-orb