CircleCI-Public / browser-tools-orb

Quickly and easily install common browsers and browser testing tools on CircleCI
https://circleci.com/developer/orbs/orb/circleci/browser-tools
MIT License
24 stars 34 forks source link

fix: dynamic CDN URL based on chrome-for-testing version #105

Closed cbrews closed 9 months ago

cbrews commented 9 months ago

Checklist

Motivation, issues

This is a possible solution to https://github.com/CircleCI-Public/browser-tools-orb/issues/104.

A possibly better solution would be to update the script to not infer the URL but rather read from https://googlechromelabs.github.io/chrome-for-testing/latest-versions-per-milestone-with-downloads.json to get the download link directly. I probably recommend that over this solution, so if someone wants to tackle, go for it.

Description

The chrome-for-testing release moved newer versions of chromedriver >= 121 to a new CDN (leaving older versions in place). See this commit: https://github.com/GoogleChromeLabs/chrome-for-testing/commit/3bfd77e1ea8df7b38651780351ab619f52d19aa2

Hard to say for sure if this was completely intended but assuming this is their plan moving forward for storage of release versions, we should point to the right CDN location.

I would probably wait on this PR for a few days to make sure nothing changes again though.

chrismo commented 9 months ago

As a paying customer, I really hope CircleCI fixes this properly. These sort of problems have been happening somewhat frequently over the past few months. Please, please, please, make this more resilient. Please also add a fallback so the rest of your customer base that uses this orb doesn't have to patch their CI configs every time the chrome team gets creative with how they store their stuff.

loromagnoni commented 9 months ago

This issue is blocking for not centos and debian executors, since the workaround only applies to those environments. Merging this fix would help 🙏

SemanticallyNull commented 9 months ago

@cbrews Thank you for submitting this PR. This is now available in v1.4.7