fix(install-chrome.sh): Chrome install not working on ARM executors

CircleCI-Public / browser-tools-orb

Quickly and easily install common browsers and browser testing tools on CircleCI

https://circleci.com/developer/orbs/orb/circleci/browser-tools

MIT License

23 stars 34 forks source link

fix(install-chrome.sh): Chrome install not working on ARM executors #73

Closed itsyuvalcohen closed 1 year ago

itsyuvalcohen commented 1 year ago

Checklist

[x] All new jobs, commands, executors, parameters have descriptions
[x] Examples have been added for any significant new features
[x] README has been updated, if necessary

Motivation, issues

Chrome installations on ARM executors fails due to a bad architecture check causing it to use amd64 instead of arm64

Description

Fixed ENV_IS_ARM variable

itsyuvalcohen commented 1 year ago

Thanks for the contribution, I left a note in your changes

I figured out google doesn't even publish google-chrome-stable for arm64, I think we should exit with an error saying it isn't supported

ryanbourdais commented 1 year ago

Thanks for the contribution, I left a note in your changes

I figured out google doesn't even publish google-chrome-stable for arm64, I think we should exit with an error saying it isn't supported

If you would like to make that change on this PR I can get that merged in, otherwise I can just close this PR out.

m3thom commented 2 months ago

If I understand correctly, we should be able to install Chrome on ARM when this issue is resolved, no? https://github.com/GoogleChromeLabs/chrome-for-testing/issues/1