CircleCI-Public / browser-tools-orb

Quickly and easily install common browsers and browser testing tools on CircleCI
https://circleci.com/developer/orbs/orb/circleci/browser-tools
MIT License
23 stars 34 forks source link

`install-chromedriver` is broken for Chrome >= 115 which is stable and latest release today #75

Closed bericp1 closed 1 year ago

bericp1 commented 1 year ago

Orb version

circleci/browser-tools@1.4.1 (latest as of writing)

What happened

chromedriver install fails:

This is because the chromedriver team migrated to a new set of JSON APIs for >=115

https://sites.google.com/chromium.org/driver/?pli=1#:~:text=Starting%20with%20M115%20the%20latest%20Chrome%20%2B%20ChromeDriver%20releases%20per%20release%20channel%20(Stable%2C%20Beta%2C%20Dev%2C%20Canary)%20are%20available%20at%20the%20Chrome%20for%20Testing%20availability%20dashboard.%20For%20automated%20version%20downloading%20one%20can%20use%20the%20convenient%20JSON%20endpoints.

Expected behavior

ChromeDriver installs

sedghi commented 9 months ago

I think i'm on latest? https://github.com/OHIF/Viewers/blob/master/.circleci/config.yml I don't specify it really

hoylemd commented 9 months ago

I think it's the cypress orb that's out of date https://github.com/cypress-io/circleci-orb/blob/0aa1d98771c497bc17d5be3def522a2ab5f88013/src/%40orb.yml#L10

artemgurzhii commented 4 months ago
Google Chrome is not currently installed; installing it
Preparing Chrome installation for Debian-based systems
https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_114.0.5735.90-1_amd64.deb:
2024-05-16 08:04:25 ERROR 404: Not Found.
/bin/bash: line 130: google-chrome-stable: command not found
Google Chrome v114.0.5735.90 (stable) failed to install.

Exited with code exit status 1
craigd-lumin commented 4 months ago

Same for me. Google Chrome is not currently installed; installing it Preparing Chrome installation for Debian-based systems https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_114.0.5735.90-1_amd64.deb: 2024-05-16 09:02:39 ERROR 404: Not Found. /bin/bash: line 130: google-chrome-stable: command not found Google Chrome v114.0.5735.90 (stable) failed to install.

jmetric commented 4 months ago
Google Chrome is not currently installed; installing it
Preparing Chrome installation for Debian-based systems
https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_114.0.5735.90-1_amd64.deb:
2024-05-16 08:04:25 ERROR 404: Not Found.
/bin/bash: line 130: google-chrome-stable: command not found
Google Chrome v114.0.5735.90 (stable) failed to install.

Exited with code exit status 1

This solution may not work if you are using MacOS, but we upgraded our browser tools to 1.4.2 (browser-tools: circleci/browser-tools@1.4.2) and removed the explicit browser-tools/install-browser-tools: #chrome-version: 114.0.5735.90 lines and this resolved the issue for us.

Google appears to have made several changes to Chrome versions yesterday (https://chromereleases.googleblog.com/2024/) though I was unable to find a reference to version 114.

adamdupuis commented 4 months ago

@artemgurzhii @craigd-lumin

Make sure you are using a more recent version of browser-tools. I'm using circleci/browser-tools@1.4.8. I had to begin using Chrome v116.0.5845.96 or greater:

- browser-tools/install-chrome:
    chrome-version: "116.0.5845.96"

The problem is these old versions are removed from Google's mirrors. This version will likely be removed in the next month or so. I had assumed the new versions of browser-tools would resolve this issue, but I guess not.

mightystrong commented 4 months ago

Same for me. Google Chrome is not currently installed; installing it Preparing Chrome installation for Debian-based systems https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_114.0.5735.90-1_amd64.deb: 2024-05-16 09:02:39 ERROR 404: Not Found. /bin/bash: line 130: google-chrome-stable: command not found Google Chrome v114.0.5735.90 (stable) failed to install.

We experienced this issue frequently. The following implementation has been stable. Specific chrome versions are hit or miss as Google doesn't consistently maintain availability.

orbs:
  browser-tools: circleci/browser-tools@1.4.6
.
.
.
    steps:
      - attach_workspace:
          at: /your/workspace
      - browser-tools/install-chrome
      - run:
          command: |
            google-chrome --version
          name: Check install
      - checkout
.
.
.
artemgurzhii commented 4 months ago

@adamdupuis thank you for help! we were having browser-tools: circleci/browser-tools@1.4.2 and chrome-version: 114.0.5735.90, replaced with browser-tools: circleci/browser-tools@1.4.8 and chrome-version: 116.0.5845.96, works fine now!

craigd-lumin commented 4 months ago

Thanks for the help @adamdupuis , much appreciated!

levischuckeats commented 3 months ago

Our team ran into this and no matter what version we tried, no chrome version listed on chrome driver downloads would resolve. The solution I came up with was to swap out the install section with the following script for debian environments:

      - run: |
          echo 'deb http://dl.google.com/linux/chrome/deb/ stable main' | sudo tee -a /etc/apt/sources.list.d/chrome.list
          wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | sudo apt-key add -
          sudo apt-get update
          sudo apt-get install -y google-chrome-stable