search

CircleCI-Public / cimg-android

The CircleCI Android Docker Convenience Image.
MIT License
75 stars 37 forks source link

Add missing variants, tag v2021.09.2 #22

Closed kmsbernard closed 2 years ago

kmsbernard commented 2 years ago

I found that missing variants in the manifest file: browsers and node. These variants described as available in the README. This PR adds those two variants in the manifest file.

I also added Dockerfiles with tag 2021.09.2 via script, but I'm not sure I could do this. (perhaps only for the maintainer during release?)

FelicianoTech commented 2 years ago

Hi. Thank you for the PR. These changes look good and are needed so thank you. I was about to do them myself until I saw you provided them already. Just two notes:

  1. Yes we would handle the release tag ourselfs so you don't need to worry about determining the tag/version.
  2. We don't edit Dockerfiles directly. Instead, there's a Dockerfile.template file that we make changes to, then the Dockerfiles are generated from there. In this scenario I'm going to go ahead and merge your work since we're switching over to October for the tag, but just a note for the future. Thank you!
FelicianoTech commented 2 years ago

Actually, I don't see that Dockerfile.template was updated in the "Files Changes" tab on GitHub but when I look at the actual code, it was. So ignore point number 2 that I made. This PR seems to have done that part correctly.

Again, thank you!