search

CircleCI-Public / cimg-android

The CircleCI Android Docker Convenience Image.
MIT License
75 stars 37 forks source link

Add SDK 31.0.0 #27

Closed chrisjenx closed 2 years ago

chrisjenx commented 2 years ago

Ahh ok On Fri, Dec 10, 2021 at 7:47 AM Ricardo N Feliciano < @.***> wrote:

@.**** requested changes on this pull request.

Hi. Thank you for the PR. The change itself is great however how we add it to the image needs to be modified.

For Convenience Images such as this Android one, changes should be made to the Dockerfile.template file only. Dockerfiles shouldn't be edited directly and previous images shouldn't be edited and we don't rebuild them.

So if you can make this change just to the template file, we can get this merged and this change will appear in the next image release for Android.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CircleCI-Public/cimg-android/pull/27#pullrequestreview-828976008, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI5DMJ54NFR43SDJ7YAOX3UQIHGPANCNFSM5JCQ7RFA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

FelicianoTech commented 2 years ago

Closing due to a lack of progress at this time.