search

CircleCI-Public / cimg-android

The CircleCI Android Docker Convenience Image.
MIT License
72 stars 37 forks source link

chore: docker comment about default jdk version, 11 to 17 #79

Closed RyuNen344 closed 1 year ago

RyuNen344 commented 1 year ago

In 2023.03 and 2023.04, default JDK was changed to version 17. It appears that there was a missed update to the comments in the Dockerfile, so we have made the necessary changes to address this.

ryanbourdais commented 1 year ago

Hi @RyuNen344 thank you for the contribution. We don't edit dockerfiles directly, normally I would ask you to make your changes to Dockerfile.template and run ./shared/gen-dockerfiles.sh [month tag], but because the april image is already released I think it is best to ask you to only change Dockerfile.template and allow this fix to reflect on all future releases. If you are able, can you make this change? Thank you

RyuNen344 commented 1 year ago

@ryanbourdais I apologize for not understanding the flow of generating Docker files. Thank you for the suggestion, I will submit a PR there. so, this PR close.