search

CircleCI-Public / cimg-node

The CircleCI Node.js Docker Convenience Image.
https://circleci.com/developer/images/image/cimg/node
MIT License
41 stars 33 forks source link

Feature Request: Update open JDK to the next LTS #352

Closed rvdkraan closed 1 year ago

rvdkraan commented 1 year ago

Describe the Feature Request Please update the Open JDK for Java to the next LTS version. The current one is about to be depricated.

Is your feature request related to a particular problem? Our workflow gives a warning the the current Java version is soon to be depricated.

How will this feature request benefit CircleCI jobs using this image? To be able to use this cimg the java version needs to be updated or we need to create a custum image.

Describe the solution you would like to see update open JDK to version 17

Describe alternatives you have considered none

TheMetalCode commented 1 year ago

I don't think cimg/node has java installed to begin with.

➜  ~ docker run -i -t cimg/node:current bash
circleci@42f7843c3f8a:~/project$ java --version
bash: java: command not found
circleci@42f7843c3f8a:~/project$ which java
circleci@42f7843c3f8a:~/project$ echo $JAVA_HOME

See also https://github.com/CircleCI-Public/cimg-node/blob/main/20.5/Dockerfile#L9

You may wish to provide more detail about which part of your workflow is throwing warnings about java version. In my case, it was Sonarcloud scans and upgrading to v5 of the sonar-scanner-cli (which is build with java 17 instead of 11) resolved the warning.

rvdkraan commented 1 year ago

Hi Jason

You are correct. I was wondering how Java ended up in the image. The sonar scanner uses an embedded version of java.

In my case I use the scanner from npm which is in progress to be updated to java 17. https://community.sonarsource.com/t/java-11-is-deprecated-as-a-runtime-env-to-scan-your-projects/96597

Thanks for your help.

From: Jason Hagglund @.> Sent: Thursday, 10 August 2023 21:39 To: CircleCI-Public/cimg-node @.> Cc: Ruben van der Kraan @.>; Author @.> Subject: Re: [CircleCI-Public/cimg-node] Feature Request: Update open JDK to the next LTS (Issue #352)

I don't think cimg/node has java installed to begin with.

➜ ~ docker run -i -t cimg/node:current bash

@.***:~/project$ java --version

bash: java: command not found

@.***:~/project$ which java

@.***:~/project$ echo $JAVA_HOME

See also https://github.com/CircleCI-Public/cimg-node/blob/main/20.5/Dockerfile#L9

You may wish to provide more detail about which part of your workflow is throwing warnings about java version. In my case, it was Sonarcloud scans and upgrading to v5 of the sonar-scanner-cli (which is build with java 17 instead of 11) resolved the warning.

— Reply to this email directly, view it on GitHubhttps://github.com/CircleCI-Public/cimg-node/issues/352#issuecomment-1673805092, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALGSDZDIXN2XNZ7NAFPFCH3XUU2GRANCNFSM6AAAAAA3IIJPY4. You are receiving this because you authored the thread.Message ID: @.**@.>>

BytesGuy commented 1 year ago

Hi, I can confirm Java is not included in this image, therefore I am closing this issue. Thanks!

nielsvaneck commented 1 year ago

the -browsers versions of these images include java 11