CircleCI-Public / cimg-node

The CircleCI Node.js Docker Convenience Image.
https://circleci.com/developer/images/image/cimg/node
MIT License
41 stars 33 forks source link

Update `yarn` to `1.22.22` #376

Closed DoodleBobBuffPants closed 2 months ago

DoodleBobBuffPants commented 9 months ago

For our official CircleCI Docker Convenience Image support policy, please see CircleCI docs.

This policy outlines the release, update, and deprecation policy for CircleCI Docker Convenience Images.


Description

A brief description of the changes in this PR.

Updates yarn from 1.22.19 to 1.22.22

Reasons

Please provide reasoning for these changes and how this PR achieves them.

If applicable, include a link to the related GitHub issue that this PR will close.

Patch version update to pick up fixes for https://github.com/yarnpkg/yarn/issues/9005

Checklist

Please check through the following before opening your PR. Thank you!

JalexChen commented 9 months ago

Hi @DoodleBobBuffPants - we are going off the classic stable release per yarn docs. Additionally, it looks like the newest versions of yarn have a couple of warnings against them on the releases page. I think placing this PR in the backlog until these are resolved so as to not break builds might be the best option for now.

@ryanbourdais - any thoughts?

schinery commented 3 months ago

A 1.22.22 version has been released that doesn't have the don't use warnings in.

Screenshot 2024-05-28 at 13 50 37

@JalexChen would it be good for @DoodleBobBuffPants to update this PR to use that instead?

schinery commented 3 months ago

Maybe @DoodleBobBuffPants update this PR to 1.22.22 so it is good to go when someone gets around to looking at it again...

schinery commented 2 months ago

@JalexChen do you think this is good now to get merged so it's available in the next Node releases?