search

CircleCI-Public / cimg-openjdk

The CircleCI OpenJDK (Java) Docker Convenience Image.
https://circleci.com/developer/images/image/cimg/openjdk
MIT License
18 stars 25 forks source link

Add symlinks for the whole bin directory #143

Closed StefanBratanov closed 1 year ago

StefanBratanov commented 1 year ago

Thought it would be useful to have everything under the $JAVA_HOME/bin directory symlinked.

fixes #142

JalexChen commented 1 year ago

hi @StefanBratanov - thanks for submitting the PR. i think this could be useful and i would be on board. this works if the user is not switching between java versions, which the cimgs are intended to do. @felicianotech - can you take a look and share any thoughts or objections?

otherwise, could you please edit the PR to only make the change in the Dockerfile.template file? Since this is not a security patch, by policy we won't be republishing images, but subsequent releases will include this feature.

StefanBratanov commented 1 year ago

hi @StefanBratanov - thanks for submitting the PR. i think this could be useful and i would be on board. this works if the user is not switching between java versions, which the cimgs are intended to do. @felicianotech - can you take a look and share any thoughts or objections?

otherwise, could you please edit the PR to only make the change in the Dockerfile.template file? Since this is not a security patch, by policy we won't be republishing images, but subsequent releases will include this feature.

Hi @JalexChen thanks for looking into the PR. I edited the change to be only in the template file.