search

CircleCI-Public / cimg-openjdk

The CircleCI OpenJDK (Java) Docker Convenience Image.
https://circleci.com/developer/images/image/cimg/openjdk
MIT License
18 stars 25 forks source link

Java 8 people still using #91

Closed nhojpatrick closed 3 years ago

nhojpatrick commented 3 years ago

Reinstate java 8, as loads of projects still using it.

FelicianoTech commented 3 years ago

Hi. I am going to close this PR because 1) Java 8 is not gone. It's available. And 2) this PR seems to include unrelated changes to what you are referring to. I've commented in one of your other PRs where we can potentially continue this work, if needed.

nhojpatrick commented 3 years ago

Hi. I am going to close this PR because 1) Java 8 is not gone. It's available. And 2) this PR seems to include unrelated changes to what you are referring to. I've commented in one of your other PRs where we can potentially continue this work, if needed.

I misunderstood build-images.sh then, as I took that as how you generated your images and publish them and it's missing Java 8. I can see the Dockerfile exists, but It looked like it wasn't being published still.