CircleCI-Public / cimg-ruby

The CircleCI Ruby Docker Convenience Image.

https://circleci.com/developer/images/image/cimg/ruby

MIT License

33 stars 39 forks source link

Publish v3.3.0. [release] #150

Closed ksylvest closed 10 months ago

ksylvest commented 10 months ago

Description

Support for Ruby 3.3.0.

Reasons

To support the latest release of Ruby on CircleCI without needing to manually install.

Checklist

Please check through the following before opening your PR. Thank you!

[x] I have made changes to the Dockerfile.template file only
[x] I have not made any manual changes to automatically generated files
[x] My PR follows best practices as described in the contributing guidelines
[x] (Optional, but recommended) My commits are signed

schinery commented 10 months ago

@ksylvest did you use ./shared/release.sh 3.3.0 to generate the files for this PR?

Only asking as the PR title needs to include [release] in it for when it is merged and that script normally generates the PR title like "Publish v3.3.0. [release]". Details here.

Edit:

Tried ./shared/release.sh 3.3.0 myself and got the same changes, so hopefully it is just a case of updating the PR title and @JalexChen or someone can approve this 🙏🏻

ryanbourdais commented 10 months ago

Closing in favor of https://github.com/CircleCI-Public/cimg-ruby/pull/153

ksylvest commented 10 months ago

@schinery I've adjusted title, but not sure if it matters given closed in favour of 153.

JalexChen commented 10 months ago

@ksylvest - some context:

@schinery's point about using the ./shared/release script is correct. this is the section of the README that explains it. In doing so, we can make changes to the dockerfile without inadvertently releasing a new version.

We typically would use this PR, but Ryan provided an explanation in the other PR. We do appreciate the effort and I hope this doesn't discourage contributions from you in the future.