search

CircleCI-Public / cimg-ruby

The CircleCI Ruby Docker Convenience Image.
https://circleci.com/developer/images/image/cimg/ruby
MIT License
33 stars 39 forks source link

Publish v3.3.0. [release] #153

Closed ryanbourdais closed 10 months ago

ryanbourdais commented 10 months ago

Publish v3.3.0. [release]

ksylvest commented 10 months ago

@JalexChen @ryanbourdais I'm confuse on the process for PRs into this repo. I opened an identical PR a few days ago that got closed without an explanation:

https://github.com/CircleCI-Public/cimg-ruby/pull/150 (also tracked via https://github.com/CircleCI-Public/cimg-ruby/issues/149)

Are you interested in contributions from non CircleCI employees? If not, it might be be worth adding details in README that it isn't open to contributions.

ryanbourdais commented 10 months ago

Hi @ksylvest we usually are interested in contributions from non CircleCI employees, this instance was superseded because of customer drive for the 3.3.0 release. There were some changes that needed to be made in #150 and in the interest of time I opened this PR to get the image out as fast as possible to customers. Typically we won't do this and would rather use a non-employee's PR, this is just a special case driven by the release over the holiday.

ksylvest commented 10 months ago

@ryanbourdais Thanks for clarifying. I think unfortunately this published image has a bad flag for jemalloc making it unusable for many projects.

Do you mind reviewing: https://github.com/CircleCI-Public/cimg-ruby/pull/156 / https://github.com/CircleCI-Public/cimg-ruby/issues/155