search

CircleCI-Public / cimg-rust

The CircleCI Rust Docker Convenience Image.
https://circleci.com/developer/images/image/cimg/rust
MIT License
15 stars 10 forks source link

Publishing to Docker Hub not working after default branch rename to `main` #64

Closed edmorley closed 3 years ago

edmorley commented 3 years ago

Hi!

Rust 1.56 support was added in #63, which would normally be automatically published to Docker Hub after the PR is merged.

However the 1.56 tags are not present at: https://hub.docker.com/r/cimg/rust/tags

Checking the CircleCI job, I see it ran, but the final publish was skipped: https://app.circleci.com/pipelines/github/CircleCI-Public/cimg-rust/811/workflows/39407274-097d-4810-a8fe-16272e140c45/jobs/2202

This appears to be because that step is expecting the default branch name to be master: https://github.com/CircleCI-Public/cimg-rust/blob/1e9aebe7e063ee1b1731bfca0285d9d74dca1a58/.circleci/config.yml#L21-L24

...whereas the default branch is now main (I presume it was renamed recently?).

cc @felicianotech

FelicianoTech commented 3 years ago

Yes, good catch. I will get this fixed shortly.

FelicianoTech commented 3 years ago

It's available now.

edmorley commented 3 years ago

Thank you :-)