Closed or-shachar closed 7 months ago
Love the idea! This should be simple to merge. I think the feature has a few more requirements:
--http_timeout
is setup? Did you do that part? Also, from the user's point of view, I don't think it matters that this is HTTP in the flag. Let's just call it --timeout
and add the HTTP part to the inline help.HTTP_TIMEOUT
seems like too generic a term. Can we add a prefix to "namespace" the environment variable? CIRCLECI_CLI_TIMEOUT=30s
should do fine.Finally, I'd like to see at least one test in there. You can add an integration test to config/commands_test.go
, creating a new mock server with httptest.NewServer
that takes longer time to respond than the timeout.
Let me know if any of this is unclear, I'll be glad to help.
@or-shachar cli released you can define http timeout now
What problem does this feature solve?:
circleci config process / validate
commandscircleci
fails to execute due to timeout.Provide an example:
or