CircleCI-Public / circleci-cli

Use CircleCI from the command line
https://circleci-public.github.io/circleci-cli/
MIT License
404 stars 233 forks source link

[SNC-371] Sending compiled config in policy `decide` and `eval` subcommands #964

Closed sagar-connect closed 11 months ago

sagar-connect commented 11 months ago

Checklist

=========

Internal Checklist

Changes

=======

Rationale

=========

What was the overarching product goal of this PR as well as any pertinent history of changes

Considerations

==============

Why you made some of the technical decisions that you made, especially if the reasoning is not immediately obvious

Screenshots

============

Before

Image or gif

After

Image or gif where change can be clearly seen

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from main.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.
sagar-connect commented 11 months ago

LGTM not sure how to test pipeline-parameters though

Right. The tests around pipeline-parameters aren't really relevant to these changes as they would be testing that they are parsed and sent to /api/v2 correctly. Since these changes are reusing cofig.ProcessConfig method for parsing the pipelines-parameters, it's relying on the existing tests around it.