Closed sagar-connect closed 11 months ago
LGTM not sure how to test
pipeline-parameters
though
Right. The tests around pipeline-parameters aren't really relevant to these changes as they would be testing that they are parsed and sent to /api/v2 correctly. Since these changes are reusing cofig.ProcessConfig method for parsing the pipelines-parameters, it's relying on the existing tests around it.
Checklist
=========
Internal Checklist
Changes
=======
decide
andeval
subcommandsRationale
=========
What was the overarching product goal of this PR as well as any pertinent history of changes
Considerations
==============
Why you made some of the technical decisions that you made, especially if the reasoning is not immediately obvious
Screenshots
============
Before
Image or gif
After
Image or gif where change can be clearly seen
Here are some helpful tips you can follow when submitting a pull request:
main
.make build
in the repository root.make test
).--debug
flag is often helpful for debugging HTTP client requests and responses.make lint
). Note: This requires Docker to run inside a local job.