loderunner commented 11 months ago

Checklist

=========

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have checked for similar issues and haven't found anything relevant.
[x] This is not a security issue (which should be reported here: https://circleci.com/security/)
[x] I have read Contribution Guidelines.

Internal Checklist

[x] I am requesting a review from my own team as well as the owning team
[x] I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

During circleci local execute, make it possible to configure temporary directory to store config file.

Rationale

This was needed to support alternative (aka "not Docker") container distributions on macOS, particularly lima-based distributions, such as colima or Rancher Desktop, that do not support mounting /tmp (or other "system paths") to their Linux VM.

Considerations

the temporary directory can be configured as a flag to local execute, or inside the cli.yml settings file with the temp_dir property, otherwise it defaults to the system's temporary dir
- (in order of precedence)
inspired by #716 (thanks @samahatw!)
removes hard dependency on /tmp, instead reverting to system temp dir, as Docker Desktop now adds /var/folders to its mount paths