Closed ryan-wren closed 11 months ago
The original PR for these changes is here - https://github.com/CircleCI-Public/circleci-cli/pull/974 , but I messed up doing a rebase.
@vallieres I switched the logic as suggested to upload results from the Snyk scans on the dev branch. Here is the before screenshot:
And here is the after screenshot:
So, the results were uploaded to Snyk for this branch as expected. I'll delete the projects that were created from this branch. And I switched the logic back to only upload results on the main
branch.
Checklist
=========
Internal Checklist
Changes
=======
vulnerability-scan
job to the CircleCI config, to run Snyk scans and monitoringRationale
=========
The Snyk scans should be used to discover vulnerabilities in this project.
Considerations
==============
Why you made some of the technical decisions that you made, especially if the reasoning is not immediately obvious
Screenshots
============
Before
Image or gif
After
Image or gif where change can be clearly seen
Here are some helpful tips you can follow when submitting a pull request:
main
.make build
in the repository root.make test
).--debug
flag is often helpful for debugging HTTP client requests and responses.make lint
). Note: This requires Docker to run inside a local job.