CircleCI-Public / circleci-cli

Use CircleCI from the command line
https://circleci-public.github.io/circleci-cli/
MIT License
404 stars 233 forks source link

Add Snyk scanning & monitoring #978

Closed ryan-wren closed 11 months ago

ryan-wren commented 11 months ago

Checklist

=========

Internal Checklist

Changes

=======

Rationale

=========

The Snyk scans should be used to discover vulnerabilities in this project.

Considerations

==============

Why you made some of the technical decisions that you made, especially if the reasoning is not immediately obvious

Screenshots

============

Before

Image or gif

After

Image or gif where change can be clearly seen

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from main.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.
ryan-wren commented 11 months ago

The original PR for these changes is here - https://github.com/CircleCI-Public/circleci-cli/pull/974 , but I messed up doing a rebase.

@vallieres I switched the logic as suggested to upload results from the Snyk scans on the dev branch. Here is the before screenshot: Screenshot 2023-08-01 at 13 28 43

And here is the after screenshot: Screenshot 2023-08-01 at 13 38 11

So, the results were uploaded to Snyk for this branch as expected. I'll delete the projects that were created from this branch. And I switched the logic back to only upload results on the main branch.