search

CircleCI-Public / circleci-config-sdk-ts

Generate CircleCI Configuration YAML from JavaScript or TypeScript. Use Dynamic Configuration and the Config SDK together for live generative config.
https://circleci-public.github.io/circleci-config-sdk-ts/
Apache License 2.0
82 stars 29 forks source link

feat: parsing upgrades #113

Closed Jaryt closed 2 years ago

ghost commented 2 years ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=113&src=https%3A%2F%2Fgithub.com%2FCircleCI-Public%2Fcircleci-config-sdk-ts)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

codecov[bot] commented 2 years ago

Codecov Report

Merging #113 (f2b4719) into main (48bff2c) will decrease coverage by 0.72%. The diff coverage is 92.85%.

@@             Coverage Diff             @@
##              main     #113      +/-   ##
===========================================
- Coverage   100.00%   99.27%   -0.73%     
===========================================
  Files          106      107       +1     
  Lines         1025     1098      +73     
  Branches        87      113      +26     
===========================================
+ Hits          1025     1090      +65     
- Misses           0        2       +2     
- Partials         0        6       +6
Impacted Files Coverage Δ
...ts/Commands/schemas/Native/Cache/Restore.schema.ts 100.00% <ø> (ø)
...ommands/schemas/Reusable/ReusableCommand.schema.ts 100.00% <ø> (ø)
...rc/lib/Components/Commands/schemas/Steps.schema.ts 100.00% <ø> (ø)
src/lib/Config/types/index.ts 100.00% <ø> (ø)
src/lib/Config/exports/Validator.ts 96.66% <66.66%> (-3.34%) :arrow_down:
src/lib/Orb/parsers/index.ts 86.20% <86.20%> (ø)
src/lib/Components/Commands/parsers/index.ts 96.66% <86.66%> (-3.34%) :arrow_down:
src/lib/Components/Workflow/parsers/index.ts 97.67% <95.65%> (-2.33%) :arrow_down:
...lib/Components/Commands/exports/Native/Checkout.ts 100.00% <100.00%> (ø)
...nents/Commands/exports/Reusable/ReusableCommand.ts 100.00% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

KyleTryon commented 2 years ago

If this is still relevant, we should move this to https://github.com/CircleCI-Public/circleci-config-parser-ts