CircleCI-Public / circleci-config-sdk-ts

Generate CircleCI Configuration YAML from JavaScript or TypeScript. Use Dynamic Configuration and the Config SDK together for live generative config.
https://circleci-public.github.io/circleci-config-sdk-ts/
Apache License 2.0
82 stars 29 forks source link

refactor!: Improved implementation of execution properties #136

Closed Jaryt closed 2 years ago

Jaryt commented 2 years ago
ghost commented 2 years ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=136&src=https%3A%2F%2Fgithub.com%2FCircleCI-Public%2Fcircleci-config-sdk-ts)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

codecov[bot] commented 2 years ago

Codecov Report

Merging #136 (a5d29f4) into main (b632bbf) will decrease coverage by 1.36%. The diff coverage is 63.33%.

@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   98.75%   97.38%   -1.37%     
==========================================
  Files          61       61              
  Lines         640      651      +11     
  Branches       54       61       +7     
==========================================
+ Hits          632      634       +2     
- Misses          5        7       +2     
- Partials        3       10       +7     
Impacted Files Coverage Δ
src/lib/Components/Commands/exports/Native/Run.ts 85.71% <ø> (ø)
...rc/lib/Components/Executors/exports/DockerImage.ts 100.00% <ø> (ø)
src/lib/Components/Executors/exports/Executor.ts 100.00% <ø> (+18.18%) :arrow_up:
...lib/Components/Executors/exports/DockerExecutor.ts 60.71% <38.88%> (-39.29%) :arrow_down:
.../lib/Components/Executors/exports/MacOSExecutor.ts 100.00% <100.00%> (ø)
...ib/Components/Executors/exports/MachineExecutor.ts 100.00% <100.00%> (ø)
...ib/Components/Executors/exports/WindowsExecutor.ts 100.00% <100.00%> (ø)
src/lib/Components/Job/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.