search

CircleCI-Public / circleci-config-sdk-ts

Generate CircleCI Configuration YAML from JavaScript or TypeScript. Use Dynamic Configuration and the Config SDK together for live generative config.
https://circleci-public.github.io/circleci-config-sdk-ts/
Apache License 2.0
82 stars 29 forks source link

feat!: add optional properties to parameterized jobs #139

Closed Jaryt closed 2 years ago

ghost commented 2 years ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=139&src=https%3A%2F%2Fgithub.com%2FCircleCI-Public%2Fcircleci-config-sdk-ts)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

codecov[bot] commented 2 years ago

Codecov Report

Merging #139 (6c47835) into main (33e9329) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files          61       61           
  Lines         658      658           
  Branches       64       64           
=======================================
  Hits          640      640           
  Misses          7        7           
  Partials       11       11
Impacted Files Coverage Δ
src/lib/Components/Job/exports/ParameterizedJob.ts 100.00% <100.00%> (ø)
src/lib/Components/Job/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mathieutu commented 2 years ago

We also have to add it in JobContentsShape 🙂.