Bug: Job parallelism property is not displayed

tapesec commented 2 years ago

Is there an existing issue for this?

[X] I have searched the existing issues

Current behavior

The parallelism option is supposed to available for a job. This parallelism property is available into the Job class constructor but it is not passed to the generateContents method so you can’t see it in the final generated .yml config.

Minimum reproduction code

Steps to reproduce

No response

Expected behavior

The parallelism property passed to the Job class constructor is not returned from the generateContents method. I added it.

CircleCI Config SDK version

v0.9.0-alpha.21

Node.js version

16.13.0

In which operating systems have you tested?

[X] macOS
[ ] Windows
[ ] Linux

Other

No response

tapesec commented 2 years ago

I’ve created a PR to fix it but I can’t push it because I haven’t access right. Could you grant me up please ?

KyleTryon commented 2 years ago

Hey @tapesec You should be able to open a PR from a fork without any special access. Could you link us to your branch on GitHub?

tapesec commented 2 years ago

Oh sorry my bad I cloned the repo I didn’t fork it :( Now it’s done here is the link to my PR https://github.com/CircleCI-Public/circleci-config-sdk-ts/pull/142

KyleTryon commented 2 years ago

Closed in #139

CircleCI-Public / circleci-config-sdk-ts