search

CircleCI-Public / circleci-config-sdk-ts

Generate CircleCI Configuration YAML from JavaScript or TypeScript. Use Dynamic Configuration and the Config SDK together for live generative config.
https://circleci-public.github.io/circleci-config-sdk-ts/
Apache License 2.0
82 stars 29 forks source link

docs: rename writeFile path #172

Closed TatsuyaYamamoto closed 1 year ago

TatsuyaYamamoto commented 1 year ago

I read example doc and probably found a mistake.

configuration_path: ./dynamicConfig.yml https://github.com/CircleCI-Public/circleci-config-sdk-ts/blob/main/sample/01-dynamic-workflow-javascript/.circleci/config.yml

So, I think myConfig.writeFile should received dynamicConfig.yml

ghost commented 1 year ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=172&src=https%3A%2F%2Fgithub.com%2FCircleCI-Public%2Fcircleci-config-sdk-ts)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

codecov[bot] commented 1 year ago

Codecov Report

Base: 96.16% // Head: 96.16% // No change to project coverage :thumbsup:

Coverage data is based on head (8051d7e) compared to base (00ddfb1). Patch has no changes to coverable lines.

:exclamation: Current head 8051d7e differs from pull request most recent head ff2b295. Consider uploading reports for the commit ff2b295 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #172 +/- ## ======================================= Coverage 96.16% 96.16% ======================================= Files 62 62 Lines 678 678 Branches 69 69 ======================================= Hits 652 652 Misses 11 11 Partials 15 15 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CircleCI-Public). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CircleCI-Public)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.