CircleCI-Public / circleci-config-sdk-ts

Generate CircleCI Configuration YAML from JavaScript or TypeScript. Use Dynamic Configuration and the Config SDK together for live generative config.
https://circleci-public.github.io/circleci-config-sdk-ts/
Apache License 2.0
82 stars 29 forks source link

feat: Support for shorthand run command. #86

Closed Jaryt closed 2 years ago

Jaryt commented 2 years ago

Previously, run: $command was not able to be parsed. It is now supported.

ghost commented 2 years ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=86&src=https%3A%2F%2Fgithub.com%2FCircleCI-Public%2Fcircleci-config-sdk-ts)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

codecov[bot] commented 2 years ago

Codecov Report

Merging #86 (bff677f) into main (67ada9f) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   91.52%   91.57%   +0.04%     
==========================================
  Files          91       91              
  Lines         885      890       +5     
  Branches       95       97       +2     
==========================================
+ Hits          810      815       +5     
  Misses         66       66              
  Partials        9        9              
Impacted Files Coverage Δ
src/lib/Components/Commands/exports/Native/Run.ts 77.77% <100.00%> (+11.11%) :arrow_up:
...ponents/Commands/exports/Reusable/CustomCommand.ts 94.44% <100.00%> (ø)
src/lib/Components/Commands/parsers/index.ts 80.00% <100.00%> (+0.58%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 67ada9f...bff677f. Read the comment docs.

Jaryt commented 2 years ago

Needs to be rebased into main after #85 is merged.