search

CircleCI-Public / circleci-config-sdk-ts

Generate CircleCI Configuration YAML from JavaScript or TypeScript. Use Dynamic Configuration and the Config SDK together for live generative config.
https://circleci-public.github.io/circleci-config-sdk-ts/
Apache License 2.0
82 stars 29 forks source link

test: extended generable type and name coverage #92

Closed jliby closed 2 years ago

ghost commented 2 years ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=92&src=https%3A%2F%2Fgithub.com%2FCircleCI-Public%2Fcircleci-config-sdk-ts)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

codecov[bot] commented 2 years ago

Codecov Report

Merging #92 (7f90129) into main (4f15544) will increase coverage by 2.19%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   94.84%   97.03%   +2.19%     
==========================================
  Files          92       92              
  Lines         912      912              
  Branches       84       84              
==========================================
+ Hits          865      885      +20     
+ Misses         40       20      -20     
  Partials        7        7
Impacted Files Coverage Δ
src/lib/Config/index.ts 100.00% <0.00%> (+1.92%) :arrow_up:
src/lib/Components/Commands/parsers/index.ts 92.15% <0.00%> (+3.92%) :arrow_up:
...mponents/Parameters/exports/CustomParameterList.ts 90.47% <0.00%> (+4.76%) :arrow_up:
src/lib/Components/Workflow/index.ts 100.00% <0.00%> (+5.55%) :arrow_up:
...lib/Components/Executors/exports/DockerExecutor.ts 100.00% <0.00%> (+6.25%) :arrow_up:
...b/Components/Executors/exports/ReusableExecutor.ts 100.00% <0.00%> (+6.66%) :arrow_up:
...ib/Components/Executors/exports/WindowsExecutor.ts 100.00% <0.00%> (+7.14%) :arrow_up:
src/lib/Components/Workflow/exports/WorkflowJob.ts 100.00% <0.00%> (+8.33%) :arrow_up:
.../lib/Components/Logic/exports/conditions/Truthy.ts 100.00% <0.00%> (+10.00%) :arrow_up:
...ib/Components/Executors/exports/MachineExecutor.ts 100.00% <0.00%> (+10.00%) :arrow_up:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f15544...7f90129. Read the comment docs.