search

CircleCI-Public / circleci-demo-ruby-rails

A CircleCI demo project using Ruby and Rails
https://circleci.com/gh/CircleCI-Public/circleci-demo-ruby-rails
MIT License
78 stars 293 forks source link

feat: Add rubocop for project. #38

Closed lanzhiheng closed 4 years ago

lanzhiheng commented 4 years ago

Hello @KyleTryon @gmemstr for better testing the Rubocop function in ruby-orb, I think we can integrate Rubocop in this project. Can you consider to accept this PR?

gmemstr commented 4 years ago

@lanzhiheng Would you mind adding the command to initiate rubocop commands to the .circleci/config.yml file under the "test" job? That way we can validate they work properly for the project, then update it to use the orb's own command :)

gmemstr commented 4 years ago

Thank you! 😄

lanzhiheng commented 4 years ago

@gmemstr updated. I will change to orb's own command after you publish the new version of orb. :)